runTests: propagate signal when subprocess terminated #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating a SIGSEGV which intermittently terminates an invocation of ``` .vscode-test/vscode-1.42.1/VSCode-linux-x64/code --disable-extensions --extensionDevelopmentPath=$DEVELOPMENT_PATH \ --extensionTestsPath=$EXTENSION_TESTS_PATH/index; ``` spawned by `vscode-test`, I found it desirable to determine whether the test runner was terminating due to test failures or that SIGSEGV signal. In general, I think it would be useful for the `vscode-test` client to have this information. The [documentation][1] says: ``` If the process terminated due to receipt of a signal, signal is the string name of the signal, otherwise null. One of the two [i.e. `code` and `signal`] will always be non-null. ``` [1]: https://nodejs.org/api/child_process.html#child_process_event_exit
|
LGTM, thanks 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a SIGSEGV which intermittently terminates an
invocation of
spawned by
vscode-test, I found it desirable to determine whetherthe test runner was terminating due to test failures or that SIGSEGV
signal. In general, I think it would be useful for the
vscode-testclient to have this information.
The documentation says: