Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to how shell in terminal is identified #5886

Merged
merged 3 commits into from
Jun 4, 2019

Conversation

DonJayamanne
Copy link

For #5743

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@DonJayamanne DonJayamanne merged commit a328783 into microsoft:master Jun 4, 2019
@DonJayamanne
Copy link
Author

@karrtikr Merged this PR, as we need this ASAP. and the issue was only with missing test.
I've added the test, I am assuming you are ok with me merging the PR once the tests have been added.

@Tyriar
Copy link
Member

Tyriar commented Jun 4, 2019

@DonJayamanne thanks for fixing so quickly 😃

@DonJayamanne
Copy link
Author

@Tyriar
Team effort.

@DonJayamanne DonJayamanne deleted the issue5743 branch June 6, 2019 22:23
@Tyriar Tyriar mentioned this pull request Jun 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants