Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multi root workspaces with the new language server server #4244

Merged
merged 12 commits into from
Feb 12, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Jan 31, 2019

For #3008

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #4244 into master will increase coverage by 22%.
The diff coverage is 74%.

@@           Coverage Diff            @@
##           master   #4244     +/-   ##
========================================
+ Coverage      56%     78%    +22%     
========================================
  Files         361     438     +77     
  Lines       15274   20390   +5116     
  Branches     2373    3273    +900     
========================================
+ Hits         8494   15721   +7227     
+ Misses       6236    4665   -1571     
+ Partials      544       4    -540
Flag Coverage Δ
#Linux 66% <50%> (?)
#Windows 67% <50%> (?)
#macOS 66% <50%> (?)

@karrtikr karrtikr force-pushed the lsSupport branch 4 times, most recently from c1cc3de to 1e77898 Compare February 1, 2019 00:57
@karrtikr karrtikr requested a review from DonJayamanne February 1, 2019 18:33
@karrtikr karrtikr changed the title Added support for multi root workspaces with the new language server server WIP - Added support for multi root workspaces with the new language server server Feb 5, 2019
@karrtikr karrtikr force-pushed the lsSupport branch 11 times, most recently from 6a44a0b to 16f6d20 Compare February 7, 2019 05:08
@karrtikr karrtikr closed this Feb 12, 2019
@karrtikr karrtikr reopened this Feb 12, 2019
@karrtikr karrtikr changed the title WIP - Added support for multi root workspaces with the new language server server Added support for multi root workspaces with the new language server server Feb 12, 2019
@karrtikr karrtikr changed the title Added support for multi root workspaces with the new language server server WIP - Added support for multi root workspaces with the new language server server Feb 12, 2019
@karrtikr karrtikr changed the title WIP - Added support for multi root workspaces with the new language server server Added support for multi root workspaces with the new language server server Feb 12, 2019
@karrtikr karrtikr changed the title Added support for multi root workspaces with the new language server server WIP - Added support for multi root workspaces with the new language server server Feb 12, 2019
@karrtikr karrtikr changed the title WIP - Added support for multi root workspaces with the new language server server Added support for multi root workspaces with the new language server server Feb 12, 2019
@karrtikr karrtikr closed this Feb 12, 2019
@karrtikr karrtikr reopened this Feb 12, 2019
@karrtikr karrtikr merged commit cf686d2 into microsoft:master Feb 12, 2019
@karrtikr karrtikr deleted the lsSupport branch February 12, 2019 22:27
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants