Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable start server from absolute/relative filename #400

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Enable start server from absolute/relative filename #400

merged 2 commits into from
Dec 29, 2022

Conversation

andreamah
Copy link
Contributor

@andreamah andreamah commented Dec 28, 2022 •
edited
Loading

Fixes #388

Also added a sample tasks.json for using the command.

@andreamah andreamah marked this pull request as ready for review December 28, 2022 22:32
@andreamah andreamah marked this pull request as draft December 28, 2022 22:33
@andreamah andreamah marked this pull request as ready for review December 28, 2022 22:33
@vscodenpa vscodenpa added this to the January 2023 milestone Dec 28, 2022
rzhao271
rzhao271 reviewed Dec 28, 2022
View reviewed changes
Copy link

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised by the preview paths starting with / instead of ./. Does / mean "workspace root" in this case?

@rzhao271
Copy link

/ meaning workspace root matches with microsoft/vscode#164562

LGTM

@andreamah andreamah merged commit f42d8f2 into main Dec 29, 2022
@andreamah andreamah deleted the andreamah/issue388 branch December 29, 2022 02:17
@andreamah andreamah mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@andreamah andreamah

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

Enable start server from absolute/relative filename
3 participants
@andreamah @rzhao271 @vscodenpa