Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize rest of strings #251

Merged
merged 9 commits into from
Aug 9, 2022
Merged

Localize rest of strings #251

merged 9 commits into from
Aug 9, 2022

Conversation

andreamah
Copy link
Contributor

@andreamah andreamah commented Aug 8, 2022

Fixes #221

Added localization and also formatted code.

@andreamah andreamah marked this pull request as ready for review August 9, 2022 18:06
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback :)

src/server/wsServer.ts Outdated Show resolved Hide resolved
src/task/serverTaskTerminal.ts Outdated Show resolved Hide resolved
src/task/serverTaskTerminal.ts Outdated Show resolved Hide resolved
src/task/serverTaskTerminal.ts Outdated Show resolved Hide resolved
src/task/serverTaskTerminal.ts Outdated Show resolved Hide resolved
src/task/serverTaskTerminal.ts Outdated Show resolved Hide resolved
src/task/serverTaskTerminal.ts Outdated Show resolved Hide resolved
src/task/serverTaskTerminal.ts Outdated Show resolved Hide resolved
src/task/serverTaskTerminal.ts Outdated Show resolved Hide resolved
src/task/serverTaskTerminal.ts Outdated Show resolved Hide resolved
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@andreamah andreamah merged commit d951376 into main Aug 9, 2022
@andreamah andreamah deleted the andreamah/issue221 branch August 9, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localize rest of strings
2 participants