-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Implement ShowTextDocumentRequest #490
Conversation
@darkbasic I would like to ask you to provide this as a protocol extension like described in https://github.com/microsoft/language-server-protocol/blob/master/contributing.md. This has the advantage that we have separate files which eases the code review. We could then even have it in a next version of the LSP libraries. You could take |
@dbaeumer thanks, it's under its own standalone proposal now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darkbasic I still don't understand what a server is supposed to do if the client fails to open the editor. Could you please explain what the use case is here?
Client capabilities are now declared. |
@darkbasic I re-implemented this since a lot has changed since the creation of the PR. I will still mention you in the N&N since you are the original creator of the code. |
See microsoft/language-server-protocol#612