show resource files in src\main\resources #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaohaizh
reviewed
Nov 12, 2018
| @@ -329,6 +330,11 @@ | |||
| if (jarNode != null) { | |||
| result.add(jarNode); | |||
| } | |||
| } else if (root instanceof IFile) { | |||
| IFile file = (IFile) root; | |||
yaohaizh
reviewed
Nov 13, 2018
| @@ -337,7 +355,7 @@ | |||
|
|
|||
| private static PackageNode getJarEntryResource(JarEntryResource resource) { | |||
| if (resource instanceof JarEntryDirectory) { | |||
| return new PackageNode(resource.getName(), resource.getFullPath().toPortableString(), NodeKind.Folder); | |||
| return new PackageNode(resource.getName(), resource.getFullPath().toPortableString(), NodeKind.FOLDER); | |||
yaohaizh
reviewed
Nov 13, 2018
src/views/folderNode.ts
Outdated
| @@ -33,6 +33,6 @@ export class FolderNode extends DataNode { | |||
| } | |||
|
|
|||
| protected get iconPath(): ThemeIcon { | |||
| return ThemeIcon.Folder; | |||
| return ExplorerNode.resolveIconPath("packagefolder"); | |||
There was a problem hiding this comment.
Should use the ThemeIcon.Folder which is the VSCode provided. To keep consistent with UI. The packagefolder is for packaging only.
2. Display folders under IPackageFragmentRoot 3. Change the different display name according to normal resource folders and package folders.
yaohaizh
previously approved these changes
Nov 14, 2018
2. Provide sync to .class files
yaohaizh
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#79