feat: Add test metadata to the nodes #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
reviewed
Jan 7, 2021
| }); | ||
|
|
||
| test("test Gradle container node", async function() { | ||
| assert.equal((await gradleContainer.getTreeItem()).contextValue, "java:container+gradle+uri"); | ||
| assert.ok(/java:container(?=.*?\b\+gradle\b)(?=.*?\b\+uri\b)/.test((await gradleContainer.getTreeItem()).contextValue || "")); |
There was a problem hiding this comment.
suggest to assign human-readable names to these regular expressions...
There was a problem hiding this comment.
These are all the regexp that can be written in the package.json to register the commands to the node.
I add some comments at header to explain the purpose of this suite.
Eskibear
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
+testattributes to the test nodes.If a package fragment root has following attributes, then it is marked as a test root:
test=truemaven.scopeincludestestgradle_scopeincludestestWhen a package fragment root is a test root, then itself and all of its children will have a test attribute
+test.