Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make openFile experience consistent with built-in trees #426

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

xqzlgy2
Copy link
Contributor

@xqzlgy2 xqzlgy2 commented Dec 18, 2020

This PR changes two parts:

  1. From VS Code 1.52, all custom tree behavior has been changed, which enable our plugin to have more consistent experience with file explorer when open file. That means, all following interactions are enabled for fileNode and primaryTypeNode:
  • Double-click or mouse-middle-click to open in non-preview.
  • Enter to open in non-preview mode (Space to open in preview mode).
  • Alt+Click to open an editor to the side of the active one.

reference: https://code.visualstudio.com/updates/v1_52

  1. Since changes above needs to register vscode.open as TreeItem's command id, we can not use customized java.view.package.openFile command to send telemetry. As compensate, we send these additional info in telemetry:
  • {projectManagerVisible: 1} when project manager is expanded
  • counter for didChangeSelection, didCollapseElement, didExpandElement events

@jdneo jdneo added the enhancement New feature or request label Dec 21, 2020
@jdneo jdneo added this to the 0.17.0 milestone Dec 21, 2020
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need also update the vscode engine version to 1.52.0 to limit the impact.

src/commands.ts Show resolved Hide resolved
src/utility.ts Outdated Show resolved Hide resolved
src/views/dependencyExplorer.ts Outdated Show resolved Hide resolved
@jdneo
Copy link
Member

jdneo commented Dec 21, 2020

Thanks @xqzlgy2

@jdneo jdneo merged commit f22b0c2 into microsoft:master Dec 21, 2020
@xqzlgy2 xqzlgy2 deleted the openFile branch December 21, 2020 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants