Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change 'Reveal in Java Projects' to 'Reveal in Java Projets Explorer' #395

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Nov 30, 2020

image

@jdneo jdneo added the UX label Nov 30, 2020
@jdneo jdneo added this to the 0.16.0 milestone Nov 30, 2020
@@ -7,7 +7,7 @@
"contributes.commands.java.project.build.workspace": "Build Workspace",
"contributes.commands.java.project.clean.workspace": "Clean Workspace",
"contributes.commands.java.project.update": "Update Project",
"contributes.commands.java.view.package.revealInProjectExplorer": "Reveal in Java Projects",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Projects Explorer -> Project Explorer
Use singular form when using nouns as adjectives.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated:

image

Copy link
Member

@akaroml akaroml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jdneo jdneo merged commit b5866bf into master Nov 30, 2020
@jdneo jdneo deleted the cs/command-name branch November 30, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants