-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support managing referenced libraries #213
Conversation
1f26a1e
to
55cd56c
Compare
a54ba39
to
db6fc92
Compare
what's the status for this PR? |
Some important modifications are saved in my Linux PC. May I rebase to the master branch and update the PR after going back home tonight? |
* Notification dependency viewer to refresh on updating classpath done * Command to manually trigger classpath refreshing
812caed
to
f9d4af4
Compare
* Adding file/folder to referenced libraries * Removing a jar file from referenced libraries * Manually trigger refreshing of referenced libraries in classpath
f9d4af4
to
3b8f1c6
Compare
src/controllers/libraryController.ts
Outdated
})); | ||
} | ||
const setting = Settings.referencedLibraries(); | ||
setting.include.push(...libraryGlobs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply push might not work in some scenario, like:
if the original setting is:
"java.project.referencedLibraries": {
"include": [
"lib/**/*.jar"
],
"exclude": [
"lib/junit-platform-console-standalone-1.5.2.jar"
]
}
where the junit-platform-console-standalone-1.5.2.jar
is the only jar in the lib folder.
Now if I re-add the lib folder into the referenced libs, the exclude part won't be updated.
Fix #174, microsoft/vscode-java-pack#94
Based on:
VS Code will take care of the file watching and searching work by providng a setting:
...with the following extended behaviors before sending to
jdt.ls
:include
field.lib/
but notincluded
will be appended toexclude
field. It is to ensure jars not listened by VS Code don't get shown in referenced libraries — only one source of truth. (This is not an elegent workaround, waiting for better alternative...)foo.jar
andfoo-src.jar
(not necessarily in the same folder) will be added to sources mapping.