Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creates file watcher with trailing slash causes problems for other extensions #828

Closed
martinlippert opened this issue Apr 18, 2024 · 3 comments · Fixed by #829
Closed

creates file watcher with trailing slash causes problems for other extensions #828

martinlippert opened this issue Apr 18, 2024 · 3 comments · Fixed by #829
Assignees

Comments

@martinlippert
Copy link

Investigating microsoft/vscode-spring-boot-dashboard#324 and spring-projects/sts4#1231 revealed that the Project Manager for Java extension in VSCode seems to create a file watcher that contains a trailing slash for the root path, which should not be done (according to spring-projects/sts4#1231 (comment)).

It causes problems down the road with other extensions, since future file events when contain a wrong URI for the changed file, containing a duplicated / between the root path and the relative file path in the workspace.

@martinlippert
Copy link
Author

@testforstephen Would be awesome if you could have a look.

@testforstephen
Copy link
Contributor

this has been fixed in the pre-release version 0.23.2024041907 of Project Manager for Java extension. feel free to have a try.

@martinlippert
Copy link
Author

LGTM, thanks for this fix. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants