Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve auto-completion for dependencies #1090

Merged
merged 3 commits into from
Dec 7, 2021
Merged

feat: Improve auto-completion for dependencies #1090

merged 3 commits into from
Dec 7, 2021

Conversation

CsCherrYY
Copy link
Collaborator

@CsCherrYY CsCherrYY commented Nov 16, 2021 •
edited
Loading

newdep

fix #990, fix #981

This PR introduces the following changes:

  • Support auto completions for dependencies in local .m2 folder
  • Support auto completions for some cached dependencies from maven central
  • DependencyCompletionHandler is renamed to MavenCentralCompletionHandler to distinguish the new MavenLocalCompletionHandler
  • Now the completion in the dependencies has been limited within three parts (see the gif above)
    • groupid
    • artifaceid
    • version

@CsCherrYY CsCherrYY added the enhancement New feature or request label Nov 16, 2021
@CsCherrYY CsCherrYY added this to the 3.8.3 milestone Nov 16, 2021
@CsCherrYY CsCherrYY changed the title feat: Support dependencies completion in local .m2 folder feat: Improve auto-completion for dependencies Nov 17, 2021
@CsCherrYY CsCherrYY marked this pull request as ready for review November 17, 2021 09:12
@CsCherrYY CsCherrYY modified the milestones: 3.8.3, 3.8.4 Nov 22, 2021
@CsCherrYY CsCherrYY marked this pull request as draft November 23, 2021 02:26
@CsCherrYY CsCherrYY marked this pull request as ready for review November 24, 2021 08:12
@CsCherrYY CsCherrYY mentioned this pull request Dec 1, 2021
Closed
@CsCherrYY CsCherrYY force-pushed the cs-local-repository branch from 6ce0da2 to 92b7891 Compare December 1, 2021 07:56
Eskibear
Eskibear reviewed Dec 7, 2021
View reviewed changes
gradle-language-server/src/main/java/com/microsoft/gradle/utils/Utils.java
@@ -57,6 +61,21 @@ public static File findSubFolder(File rootFolder, String name) {
return allFiles;
}

public static List<File> listAllFiles(File folder, String ext) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider whether it's ok to use Files.walk() directly?

@CsCherrYY CsCherrYY merged commit 782785d into main Dec 7, 2021
@CsCherrYY CsCherrYY deleted the cs-local-repository branch December 7, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eskibear Eskibear Eskibear approved these changes

@jdneo jdneo Awaiting requested review from jdneo jdneo is a code owner

@testforstephen testforstephen Awaiting requested review from testforstephen testforstephen is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
December 2021
Development

Successfully merging this pull request may close these issues.

support dependencies completion in local .m2 folder Improve completion quality when querying maven central
2 participants
@CsCherrYY @Eskibear