Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ExceptionOptions; fixes #64 #88

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Conversation

weinand
Copy link
Contributor

@weinand weinand commented Nov 22, 2016

A proposal based on the 'glob pattern' approach.

@gregg-miskelly
Copy link
Member

To give an example to make sure I understand, if I wanted to break on all .NET exceptions user-unhanded, exception for System.InvalidOperationException which I want to always break on, I would get something like this?

{
  "exceptionOptions": [
    {
      "path": [
        {
          "names": [ ".NET Exceptions" ]
        }
      ],
      "breakMode": "userUnhandled"
    },
    {
      "path": [
        {
          "names": [ ".NET Exceptions", "System.InvalidOperationException" ]
        }
      ],
      "breakMode": "always"
    }
  ]
}

@weinand
Copy link
Contributor Author

weinand commented Nov 23, 2016

@gregg-miskelly the "names" array in your example is an alternation. So it would mean "always break on all exception under '.NET Exceptions' and 'System.InvalidOperationException'".

What you want is:

{
  "exceptionOptions": [
    {
      "path": [
        {
          "names": [ ".NET Exceptions" ]
        }
      ],
      "breakMode": "userUnhandled"
    },
    {
      "path": [
        {
          "names": [ ".NET Exceptions" ]
        },
        {
          "names": [ "System.InvalidOperationException" ]
        }
      ],
      "breakMode": "always"
    }
  ]
}

@weinand weinand merged commit 0299af6 into master Dec 1, 2016
@weinand weinand deleted the andre/exception_config branch December 1, 2016 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants