Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing multi-tenant support. #2560

Merged

Conversation

sevoku
Copy link
Member

@sevoku sevoku commented Feb 11, 2025

Select the right Tenant when authenticating SDK calls and pass it along to VSCode when retrieving the token from the session.

This is #2447 retargeted on V2 tree migration. I tested it with a personal tenant where I added my corporate account as a guest.

The only limitation is that attached accounts from a different tenant can't be authenticated with if localAuth is disabled. To support that we'd need to preserve the tenant when attaching accounts, but that's a corner case we can look into if we really need to.

@sevoku sevoku requested a review from a team as a code owner February 11, 2025 14:23
Select the right Tenant when authenticating SDK calls and pass it along to VSCode when retrieving the token from the session.

(cherry picked from commit 8ae59be)
@sevoku sevoku force-pushed the dev/sevoku/tree-api-migration-multitenant branch from f0a928e to e23bb1b Compare February 11, 2025 14:42
@sevoku sevoku merged commit 1bea0f7 into dev/sda/tree-api-migration Feb 11, 2025
1 check passed
@sevoku sevoku deleted the dev/sevoku/tree-api-migration-multitenant branch February 11, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants