Upgrade appservice SDK for Flex Consumption support #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What was this |
alexweininger
approved these changes
Jun 28, 2024
Oh, it was a gif showing the Functions loading faster and also Ramya's error being resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapped out my generated requests to use the SDK for flex consumption creation. Note that some things, such as runtimes and locations still use generic requests, but that's due to the fact those are not part of the appservice sdk.
Also fixed a perf bug that caused loading to take forever, especially if we had an error retrieving a function app.
Note that this will fix the error that Ramya was encountering with loading her function apps though the ones that were failing will still continue to error. I verified that those apps don't show up at all in the portal, so those resources must be in a weird state.