Use Stacks API for Flex Consumption SKU #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const getFlexStack = async (stack: string) => { | ||
| const result: AzExtPipelineResponse = await client.sendRequest(createPipelineRequest({ | ||
| method: 'GET', | ||
| url: requestUtils.createRequestUrl(`providers/Microsoft.Web/locations/${location.name}/functionAppStacks`, { |
There was a problem hiding this comment.
so flex stacks are location dependent? That's crazy
There was a problem hiding this comment.
Yeah, I can see it being helpful for this team since they have to deploy skus to regions individually (it seems like).
alexweininger
previously approved these changes
Apr 25, 2024
|
|
||
| // TODO: Because we don't have the stack API, assume no stack means it's a flex app | ||
| context.site = stack ? await this.createFunctionApp(context, rgName, siteName, stack) : await this.createFlexFunctionApp(context, rgName, siteName); | ||
| context.site = !flexSku ? |
There was a problem hiding this comment.
I prefer avoiding negating this and flipping the ternary around.
Comment on lines
240
to
+242
| url: `https://management.azure.com/subscriptions/${context.subscriptionId}/resourceGroups/${rgName}/providers/Microsoft.Web/sites/${siteName}?api-version=2023-12-01`, | ||
| method: 'PUT', | ||
| body: JSON.stringify(await this.getNewFlexSite(context)) as unknown as RequestBodyType, | ||
| body: JSON.stringify(await this.getNewFlexSite(context, sku)) as unknown as RequestBodyType, |
There was a problem hiding this comment.
not for this PR, but this will eventually need to support sovereign clouds with different request urls
alexweininger
approved these changes
May 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some different requirements for the stack API when acquiring the runtimes