Switch Dockerfile and host.json check when creating function app #4062
Conversation
| context.dockerfilePath = (await findFiles(hostPath, dockerfileGlobPattern))[0].fsPath; | ||
| // check if host.json is in the same directory as the Dockerfile | ||
| if ((await findFiles(dockerfilePath, hostFileName)).length > 0) { | ||
| context.dockerfilePath = (await findFiles(dockerfilePath, hostFileName))[0].fsPath; |
There was a problem hiding this comment.
Wouldn't this be the hostFileName path? I think if findFiles returns a length > 0, we can set context.dockerFilePath to dockerfilePath (the variable above)
There was a problem hiding this comment.
Oh that is an issue with the switcharoo I was saving just the host.json directory so the dockerfilepath just includes the directory not the full path. I'll fix that.
| context.dockerfilePath = (await findFiles(hostPath, dockerfileGlobPattern))[0].fsPath; | ||
| // check if host.json is in the same directory as the Dockerfile | ||
| if ((await findFiles(dockerfilePath, hostFileName)).length > 0) { | ||
| context.dockerfilePath = (await findFiles(dockerfilePath, dockerfileGlobPattern))[0].fsPath; |
There was a problem hiding this comment.
Why can't you just set it as
| context.dockerfilePath = (await findFiles(dockerfilePath, dockerfileGlobPattern))[0].fsPath; | |
| context.dockerfilePath = dockerfilePath; |
There was a problem hiding this comment.
dockerfile path above is set to the directory not the actualy path of the dockerfile. This is because we check the host.json path using the dockerfile directory we found. When we pass this context value to ACA it won't work with just the directory path. I can make two seperate constants and set one as the dockerfile but that seemed a little over kill, but since it seems confusing I can do that if you want.
There was a problem hiding this comment.
Well, the main thing that I wanted to avoid is to have to do another findFiles call in here, but I guess it was always like that so whatever 🤷
Switching the two checks since it is more likely that users will have a host.json in their project than a Dockerfile. This way we can abandon the check when we don't find a Dockerfile.