Print a warning if the function project root can't be found on deploy #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkfrey
force-pushed
the
main
branch
2 times, most recently
from
0c6e716 to
6bc2664
Compare
src/commands/deploy/deploy.ts
Outdated
Comment on lines
51
to
52
| await actionContext.ui.showWarningMessage(message, { stepName: "functionProjectRootNotFound" }) | ||
| return |
There was a problem hiding this comment.
Suggested change
| await actionContext.ui.showWarningMessage(message, { stepName: "functionProjectRootNotFound" }) | |
| return | |
| throw new Error(message); |
Throwing an exception here would be best as it stops execution, and will automatically show an error notification.
…deploy Inform the user that the project root could not be found instead of throwing a generic null value error and suggest a possible cause.
alexweininger
approved these changes
Jul 19, 2023
|
@mkfrey, these changes have been released in version 1.12.1 of the extension. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inform the user that the project root could not be found instead of throwing a generic null value error and suggest a possible cause.
Currently, if no hosts.json exists in the project directory (e.g. because it was accidentally deleted or not commited), the right click -> "Deploy to ..." functionality will just return the cryptic message
Internal error: Expected value to be neither null nor undefinedon the error console.This commit will let the extension show a warning message instead indicating that no project root could be found.