Verify feature flag and enable prior to deployment #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
reviewed
Apr 21, 2023
| remoteProperties[azureWebJobsFeatureFlags] = featureFlagArray.join(','); | ||
| } | ||
|
|
||
| context.telemetry.properties.addedRunFromPackage = String(shouldAddSetting); |
There was a problem hiding this comment.
Either remove this line or change addedRunFromPackage to something more accurate - depending if you want to track this in telemetry
| @@ -32,6 +44,8 @@ export async function verifyAppSettings(context: IActionContext, node: SlotTreeI | |||
| if (node.site.isLinux) { | |||
| const remoteBuildSettingsChanged = verifyLinuxRemoteBuildSettings(context, appSettings.properties, bools); | |||
| updateAppSettings ||= remoteBuildSettingsChanged; | |||
| } else if (isNodeV4Plus(options)) { | |||
There was a problem hiding this comment.
This also applies when isPythonV2Plus
| @@ -32,6 +44,8 @@ export async function verifyAppSettings(context: IActionContext, node: SlotTreeI | |||
| if (node.site.isLinux) { | |||
| const remoteBuildSettingsChanged = verifyLinuxRemoteBuildSettings(context, appSettings.properties, bools); | |||
| updateAppSettings ||= remoteBuildSettingsChanged; | |||
| } else if (isNodeV4Plus(options)) { | |||
There was a problem hiding this comment.
This should be its own if case instead of in an else if. The new Node.js programming model can be run on both windows and linux
|
getting code reviewed by the boss |
ejizba
approved these changes
Apr 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3559