Check if the passed in node is a LocalProjectTreeItem #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweininger
previously approved these changes
Oct 13, 2022
I haven't been able to repro it either. Still kinda poking around, but really not sure how it's happening. What's crazy is once you have selected something, even if you unselect it, it still passes that tree item in. Super annoying. Only way to unselect something is to reload the window. |
I noticed the same thing. Weird. |
alexweininger
approved these changes
Oct 14, 2022
nturinski
added a commit
that referenced
this pull request
Oct 15, 2022
* Check if the passed in node is a LocalProjectTreeItem * Add comment to replace isAzExtTreeItem
nturinski
added a commit
that referenced
this pull request
Oct 17, 2022
nturinski
added a commit
that referenced
this pull request
Oct 18, 2022
* Check if the passed in node is a LocalProjectTreeItem (#3370) * Check if the passed in node is a LocalProjectTreeItem * Add comment to replace isAzExtTreeItem * Changelog for patch fix * Actually save changelog... * Update version * Update date
nturinski
added a commit
that referenced
this pull request
Oct 27, 2022
* Check if the passed in node is a LocalProjectTreeItem (#3370) (#3373) * Check if the passed in node is a LocalProjectTreeItem * Add comment to replace isAzExtTreeItem * Nat/1.8.2changelog (#3375) * Check if the passed in node is a LocalProjectTreeItem (#3370) * Check if the passed in node is a LocalProjectTreeItem * Add comment to replace isAzExtTreeItem * Changelog for patch fix * Actually save changelog... * Update version * Update date * Revert addition of PyStein "feature flag" setting. (#3386) * Version bump and CHANGELOG update. (#3387) Co-authored-by: Nathan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3369
Because of this change, the Local Project tree item will get passed in to deploy which is what's causing the error.
I think when we use the new wrapper, since we pass in
nodeandnodes, it might be easier for us to tell when a node was right-clicked vs. just selected, though I'm not sure how VS Code passes us those args yet.I assume that once that changes, we can change how we do this check.