Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rtmidi] Fix configure CMakeLists.txt #9221

Merged
merged 15 commits into from
Jul 31, 2020
Merged

[rtmidi] Fix configure CMakeLists.txt #9221

merged 15 commits into from
Jul 31, 2020

Conversation

LilyWangL
Copy link
Contributor

@LilyWangL LilyWangL commented Dec 5, 2019 •
edited
Loading

Use CMakeLists.txt which is in source code to configure. It has different configurations for Windows, Linux or MacOS. Due to HMIDIIN HMIDIOUT only support desktop apps, rtmidi doesn't support target UWP. Please refer to the following docs:
HMIDIIN: https://docs.microsoft.com/en-us/previous-versions/dd798460(v%3Dvs.85)
HMIDIOUT: https://docs.microsoft.com/en-us/windows/win32/api/mmeapi/nf-mmeapi-midioutshortmsg
There are code in source file RtMidi.cpp L2394.

struct WinMidiData {
  HMIDIIN inHandle;    // Handle to Midi Input Device
  HMIDIOUT outHandle;  // Handle to Midi Output Device
  DWORD lastTime;
  MidiInApi::MidiMessage message;
  LPMIDIHDR sysexBuffer[RT_SYSEX_BUFFER_COUNT];
  CRITICAL_SECTION _mutex; // [Patrice] see https://groups.google.com/forum/#!topic/mididev/6OUjHutMpEo
};

Related issue: #6993
There are no features of this port need to test.

@LilyWangL LilyWangL added the info:internal This PR or Issue was filed by the vcpkg team. label Dec 5, 2019
@LilyWangL LilyWangL requested a review from NancyLi1013 December 5, 2019 07:19
@NancyLi1013
Copy link
Contributor

/azp run

@LilyWangL
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@PhoebeHui PhoebeHui marked this pull request as ready for review January 3, 2020 07:25
@NancyLi1013 NancyLi1013 self-assigned this Jan 14, 2020
@LilyWangL
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 22, 2020
@strega-nil
Copy link
Contributor

@LilyWangL do you still want to merge this PR? If so, could you resolve the conflicts and rerun the CI?

@LilyWangL LilyWangL marked this pull request as draft July 10, 2020 06:22
@LilyWangL LilyWangL marked this pull request as ready for review July 10, 2020 06:35
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Jul 10, 2020
@LilyWangL
Copy link
Contributor Author

@LilyWangL do you still want to merge this PR? If so, could you resolve the conflicts and rerun the CI?

Done, this PR is ready to merge.

@NancyLi1013 NancyLi1013 removed the info:reviewed Pull Request changes follow basic guidelines label Jul 17, 2020
@LilyWangL LilyWangL marked this pull request as draft July 17, 2020 08:12
@LilyWangL
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL marked this pull request as ready for review July 20, 2020 02:21
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jul 20, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 8834395 into microsoft:master Jul 31, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@LilyWangL @ras0219-msft @hellozee
[rtmidi] Fix configure CMakeLists.txt (microsoft#9221)
3c36c16 
* [rtmidi] Fix configure CMakeLists.txt

* [rtmidi] Rtmidi doesn't support "UWP"

* [rtmidi] Disable RTMIDI_API_ALSA on Linux

* [rtmidi] Update ci.baseline.txt

* [rtmidi] Fix ci.baseline.txt conflicts

* [rtmidi] Fix ci.baseline.txt conflicts

* [rtmidi] Fix ci.baseline.txt conflicts

* Update CONTROL

* Update ci.baseline.txt

* [rtmidi] Update ci.baseline.txt

* [rtmidi] Require static library to avoid issues with CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS

* Update portfile.cmake

Co-authored-by: Robert Schumacher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@vicroms vicroms

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LilyWangL @NancyLi1013 @strega-nil @ras0219-msft @vicroms