Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libmpeg2] Add new port #8871

Merged
merged 3 commits into from
May 6, 2020
Merged

[libmpeg2] Add new port #8871

merged 3 commits into from
May 6, 2020

Conversation

janisozaur
Copy link
Contributor

Libmpeg2 seems to be a somewhat old project, last release was done in
2008, but it is still in use by some projects e.g. ResidualVM

I have verified the mpeg2dec built for x86-64 with MSVC produces similar
results as the one pre-packaged on my Arch.

@NancyLi1013
Copy link
Contributor

/azp run

@grdowns grdowns changed the title [libmpeg2] Add libmpeg2 port [libmpeg2] Add new port Nov 19, 2019
NancyLi1013
NancyLi1013 suggested changes Nov 25, 2019
View reviewed changes
@NancyLi1013
Copy link
Contributor

Feature tested pass with the following triplets:

  • x86-windows (pass)

  • x64-windows-static (pass)

  • arm64-windows (pass)

  • arm-uwp (not supported)

  • x64-uwp (not supported)

This port currently only supports windows platform except for arm64-uwp, x86-uwp, x64-uwp triplets.

@janisozaur
Copy link
Contributor Author

Updated with all the requests

@janisozaur
Copy link
Contributor Author

Ping

@vicroms
Copy link
Member

vicroms commented Dec 4, 2019

/azp run

@janisozaur
Copy link
Contributor Author

Ping

@dan-shaw
Copy link
Contributor

@janisozaur Currently the MacOS pipeline is down, so we will have to wait on this.

@janisozaur
Copy link
Contributor Author

Is it required even if the package explicitly doesn't support that os? https://github.com/microsoft/vcpkg/blob/8e0d3e78284c6c8847ceea3dd1ad6f23c44997e9/ports/libmpeg2/portfile.cmake#L1

@NancyLi1013 NancyLi1013 self-assigned this Dec 17, 2019
@NancyLi1013
Copy link
Contributor

Hi @janisozaur thanks for this PR.
Since this port doesn't support osx, linux, uwp.
Could you please update ci.baseline.txt with the followings?

libmpeg2:x64-uwp=fail
libmpeg2:arm-uwp=fail
libmpeg2:x64-linux=fail
libmpeg2:x64-osx=fail

@janisozaur
Copy link
Contributor Author

Done

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Dec 20, 2019
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 9, 2020

/azp run

@ras0219-msft
Copy link
Contributor

/azp run

ras0219-msft
ras0219-msft requested changes Feb 6, 2020
View reviewed changes
@janisozaur
Copy link
Contributor Author

##[error] REGRESSION: qt5-tools:x64-linux

Unrelated regression again.

@NancyLi1013
Copy link
Contributor

Thanks for your attention.
We will fix the regression as soon as possible.

@janisozaur
Copy link
Contributor Author

All checks passing now

@NancyLi1013
Copy link
Contributor

Thanks for your reminder.
LGTM now.

@JackBoosY JackBoosY mentioned this pull request Apr 28, 2020
Merged
@janisozaur janisozaur force-pushed the libmpeg2 branch 2 times, most recently from b90cb8f to f3a8772 Compare April 30, 2020 19:29
@janisozaur
Copy link
Contributor Author

Finally all green.

strega-nil
strega-nil suggested changes May 1, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only thing I see that needs changing; this is really cool, thanks!

@janisozaur janisozaur force-pushed the libmpeg2 branch 2 times, most recently from 2b26cdf to 7bc37e6 Compare May 4, 2020 19:30
@janisozaur
Copy link
Contributor Author

Ping. It seems there is misconfiguration in the Azure Pipelines, this job has been running for close to half an hour now, in particular the x64_linux one, while this port only supports Windows and I'm sure it would take much less than this to compile vcpkg+libmpeg2 if it were supported. Previous force push also stalled for about two days.

janisozaur added 3 commits May 5, 2020 18:56
@janisozaur
[libmpeg2] Add new port
fb30ff9 
Libmpeg2 seems to be a somewhat old project, last release was done in
2008, but it is still in use by some projects e.g. ResidualVM

I have verified the mpeg2dec built for x86-64 with MSVC produces similar
results as the one pre-packaged on my Arch.
@janisozaur
[libmpeg2] Add ci.baseline.txt exemptions
ecf3ec5
@janisozaur
[libmpeg2] Apply review comments
e3acda3
@strega-nil
Copy link
Contributor

@janisozaur this looks good; I'll merge as soon as we get LLVM working again.

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY mentioned this pull request May 6, 2020
Merged
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

Alright, awesome! Thanks @janisozaur, this is great 😄

@strega-nil strega-nil merged commit 305785b into microsoft:master May 6, 2020
@janisozaur janisozaur deleted the libmpeg2 branch May 6, 2020 21:06
@janisozaur
Copy link
Contributor Author

Finally! Thanks, now on to updating that scummvm build…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil requested changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@vicroms vicroms

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@janisozaur @NancyLi1013 @vicroms @dan-shaw @ras0219-msft @JackBoosY @strega-nil