-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glib #529
Add glib #529
Conversation
Wow, this is quite an extensive port. Nice work!
|
I initially thought static builds may work, so embedded As for tools you're totally right, I didn't think about this. Moving the tools to subdir is probably the best solution although it means find_program calls won't just work :( and will have to be fed with appropriate |
Updated |
I didn't look very far into the libiconv issue; if the alternative is using a checked-in copy of libiconv, then your patch is very needed! Even in the non-static case, if the user wants to debug into
|
Yeah, glib uses iconv one way or another (on other systems just assumes it's available, on Windows unconditionally falls back to a signle-file implementation backed with WinAPI). |
It is required to build gtk+
Great, thanks for the port! |
Fixes #176.
Aside from glib port this PR adds a new function:
vcpkg_copy_tool_dependencies
, which provides dlls for installed tools. It's important that glib's tools are ready to use since other GNOME libraries often need them in the build process.