Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libmypaint ,mypaint-brushes] new ports #43601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Feb 2, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@talregev
Copy link
Contributor Author

talregev commented Feb 2, 2025

Is it ok to ask to install intltool on linux and osx machines?

@dg0yt
Copy link
Contributor

dg0yt commented Feb 3, 2025

There is (host) gettext[tools] for gettext-libintl if you ask for NLS stuff.

@talregev
Copy link
Contributor Author

talregev commented Feb 3, 2025

There is (host) gettext[tools] for gettext-libintl if you ask for NLS stuff.

I added in json file:

    {
      "name": "gettext",
      "host": true,
      "features": [
        "tools"
      ]
    },
    "gettext-libintl",

I added in portfile.cmake:

vcpkg_add_to_path(PREPEND "${CURRENT_HOST_INSTALLED_DIR}/tools/gettext/bin")

but it looking for other binaries / scrips:

configure:13799: checking for intltool-update
configure:13832: result: no
configure:13839: checking for intltool-merge
configure:13872: result: no
configure:13879: checking for intltool-extract
configure:13912: result: no
configure:13918: error: The intltool scripts were not found. Please install intltool.

@talregev
Copy link
Contributor Author

talregev commented Feb 3, 2025

How I add pkg-config executable to meson?
It not detect it correctly on android and windows arm.

@dg0yt
Copy link
Contributor

dg0yt commented Feb 4, 2025

How I add pkg-config executable to meson? It not detect it correctly on android and windows arm.

pkg-config is handled as needed. But these PR doesn't use meson AFAICS.

Looks like intltool is yet another dependency, at least with NLS enabled. But the new ports don't sufficiently control NLS.

@talregev
Copy link
Contributor Author

talregev commented Feb 4, 2025

pkg-config is handled as needed. But these PR doesn't use meson AFAICS.

This msg is from other PR. we can discuss there.

Looks like intltool is yet another dependency, at least with NLS enabled. But the new ports don't sufficiently control NLS.

What are you suggesting to do?

@dg0yt
Copy link
Contributor

dg0yt commented Feb 4, 2025

Do you want or need NLS support. If no, try if disabling it helps. If yes, get intltool.

@talregev talregev changed the title [mypaint ,mypaint-brushes] new ports [libmypaint ,mypaint-brushes] new ports Feb 4, 2025
@talregev
Copy link
Contributor Author

talregev commented Feb 4, 2025

Do you want or need NLS support. If no, try if disabling it helps. If yes, get intltool.

Let try without NLS. I found an option to disable it. Thank you.
If needed, I will try to add it in different PR.

@talregev talregev force-pushed the TalR/libmypaint branch 3 times, most recently from 3779f66 to 7761e4e Compare February 4, 2025 10:11
@talregev talregev marked this pull request as ready for review February 4, 2025 10:17
ports/libmypaint/portfile.cmake Outdated Show resolved Hide resolved
ports/libmypaint/vcpkg.json Show resolved Hide resolved
ports/mypaint-brushes/vcpkg.json Show resolved Hide resolved
ports/mypaint-brushes/vcpkg.json Outdated Show resolved Hide resolved
@Mengna-Li Mengna-Li added category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants