Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gexiv2] new port #43600

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[gexiv2] new port #43600

wants to merge 1 commit into from
+66 −0

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Feb 2, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@talregev talregev force-pushed the TalR/gexiv2 branch 2 times, most recently from 79c98d8 to 3be0379 Compare February 2, 2025 23:19
@talregev talregev marked this pull request as ready for review February 2, 2025 23:28
@talregev talregev force-pushed the TalR/gexiv2 branch 3 times, most recently from e314d3d to 5393705 Compare February 4, 2025 13:40
dg0yt
dg0yt reviewed Feb 4, 2025
View reviewed changes
ports/gexiv2/vcpkg.json
"description": "A GObject-based Exiv2 wrapper.",
"homepage": "https://gitlab.gnome.org/GNOME/gexiv2/",
"license": "GPL-2.0-or-later",
"supports": "!windows | mingw",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really no windows support?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I tried and it not compile the lib file. I am not sure why.

ports/gexiv2/portfile.cmake Outdated Show resolved Hide resolved
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talregev @dg0yt @MonicaLiu0311