Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json-glib] new port #43597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Feb 2, 2025

fix #37698

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@talregev talregev force-pushed the TalR/json-glib branch 5 times, most recently from 260d635 to 4078c4c Compare February 2, 2025 18:54
@talregev talregev marked this pull request as ready for review February 2, 2025 19:01
@talregev talregev force-pushed the TalR/json-glib branch 2 times, most recently from 49ce20a to 4078c4c Compare February 2, 2025 20:48
@talregev
Copy link
Contributor Author

talregev commented Feb 3, 2025

How I add pkg-config executable to meson?
It not detect it correctly on android and windows arm.

@dg0yt
Copy link
Contributor

dg0yt commented Feb 4, 2025

How I add pkg-config executable to meson?
It not detect it correctly on android and windows arm.

It is correctly setup and used by the build.
Until the package explicitly disables it in order to look for host programs g-ir-scanner and glib-mkenums. There program must be passed to meson via

    ADDITIONAL_BINARIES
        glib-mkenums='${CURRENT_HOST_INSTALLED_DIR}/tools/glib/glib-mkenums'
        g-ir-scanner='${GIR_TOOL_DIR}/tools/gobject-introspection/g-ir-scanner'

after setting up GIR_TOOL_DIR, cf. port gtk and others.

ports/json-glib/portfile.cmake Outdated Show resolved Hide resolved
ports/json-glib/portfile.cmake Outdated Show resolved Hide resolved
ports/json-glib/vcpkg.json Outdated Show resolved Hide resolved
@talregev talregev force-pushed the TalR/json-glib branch 9 times, most recently from f02dd5d to a0bb004 Compare February 4, 2025 13:21
@talregev
Copy link
Contributor Author

talregev commented Feb 4, 2025

I figure it out. It wasn't problem of detecting pkgconfig. It was problem of cross-build port problem.
With help of @dg0yt I figure out. Thank you.

@WangWeiLin-MV WangWeiLin-MV added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] json-glib
3 participants