Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmodbus init closes #283 #4161

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Conversation

atkawa7
Copy link
Contributor

@atkawa7 atkawa7 commented Aug 25, 2018

No description provided.

@ras0219-msft
Copy link
Contributor

Thanks for the PR!

I hardcoded the config results on windows for robustness and performance (check_xyz is very slow on windows). I also moved the include files up to the root, since that's how the library appears to document use (#include <modbus.h>). I know that for cmake users, you had added that as an include path, however we do intend to be used by more than cmake so this seems like an acceptable change :)

@alexkaratarakis alexkaratarakis merged commit c44392c into microsoft:master Aug 29, 2018
@alexkaratarakis
Copy link
Contributor

Thanks!

@atkawa7 atkawa7 deleted the libmodbus branch August 29, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants