[godot-cpp] Update to 4.3 #41246
Merged
[godot-cpp] Update to 4.3 #41246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 29, 2024 02:55
LilyWangLL
added
info:internal
7 tasks
Cheney-W
approved these changes
Sep 29, 2024
dg0yt
reviewed
Sep 29, 2024
Comment on lines
-9
to
10
| -cmake_minimum_required(VERSION 3.12) | ||
| -cmake_minimum_required(VERSION 3.13) | ||
| +cmake_minimum_required(VERSION 3.19) |
There was a problem hiding this comment.
Why does this need to be patched at all?
There was a problem hiding this comment.
This change from PR #37931 which creates this port.
There was a problem hiding this comment.
I know, but the change to 3.13 is the upstreamed change from the initial porting.
There was a problem hiding this comment.
(Note: I asked why it is necessary, not when it was added.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
godot-cppto 4.3.Usage passed on
x64-windows.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory.When updating the upstream version, the"port-version"is reset (removed fromvcpkg.json)../vcpkg x-add-version --alland committing the result.