[minio-cpp] Update to 0.2.0 #37990
Merged
[minio-cpp] Update to 0.2.0 #37990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="MinIO, Inc." |
kobalicek
force-pushed
the
minio-cpp-0.2.0
branch
2 times, most recently
from
bee4a91 to
ded774e
Compare
kobalicek
changed the title
|
CI seems stuck |
Osyotr
suggested changes
Apr 5, 2024
kobalicek
force-pushed
the
minio-cpp-0.2.0
branch
from
ded774e to
5000e42
Compare
Osyotr
approved these changes
Apr 5, 2024
ports/minio-cpp/portfile.cmake
Outdated
| vcpkg_copy_pdbs() | ||
| vcpkg_fixup_pkgconfig() | ||
|
|
||
| file(REMOVE_RECURSE |
There was a problem hiding this comment.
Nit: don't break this line so early
ports/minio-cpp/portfile.cmake
Outdated
| vcpkg_cmake_install() | ||
| vcpkg_cmake_config_fixup( | ||
| PACKAGE_NAME miniocpp | ||
| CONFIG_PATH "lib/cmake/miniocpp") |
There was a problem hiding this comment.
Nit: put ) at new line or make whole statement one line
BillyONeal
approved these changes
Apr 5, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for the update! |
7 tasks
JavierMatosD
pushed a commit
that referenced
this pull request
Apr 9, 2024
Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=101560&view=results Added `minio-cpp` to ci.baseline.txt by #29406, which has been fixed by #37990. - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [ ] ~SHA512s are updated for each updated download.~ - [ ] ~The "supports" clause reflects platforms that may be fixed by this new version.~ - [x] Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file. - [ ] ~Any patches that are no longer applied are deleted from the port's directory.~ - [ ] ~The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result.~ - [ ] ~Only one version is added to each modified port's versions file.~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.