-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fmt] Fix visibility #35793
[fmt] Fix visibility #35793
Conversation
Has this been reported upstream? /cc @vitaut |
AFAIU #29280 points also at spdlog. |
See fmtlib/fmt#3769 and fmtlib/fmt@f68f452 |
@xiaozhuai Please fix the CI pipeline error:
|
@LilyWangLL It seem nothing to do with this PR. See #33540 |
Thanks for your reply, this error should add |
./vcpkg x-add-version --all
and committing the result.When link with
spdlog
, it shows this warning.This problem was once reported in #29280 by @marcovc
And this pr fix it.