Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hwinfo] create a new port #35465

Merged
merged 5 commits into from
Dec 28, 2023
Merged

[hwinfo] create a new port #35465

merged 5 commits into from
Dec 28, 2023

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Dec 2, 2023 •
edited
Loading

Description

New port with lfreist/hwinfo#68

"supports"

  • Need to check the project's macOS CI (discarded in this version)
  • Targets Windows and Linux for now

Checklist

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@luncliff luncliff marked this pull request as draft December 2, 2023 13:18
@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 4, 2023
@luncliff luncliff marked this pull request as ready for review December 18, 2023 14:15
@BillyONeal
Copy link
Member

/azp run

@BillyONeal
Copy link
Member

Sorry I broke the build lab Sunday night

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Adela0814
Adela0814 suggested changes Dec 20, 2023
View reviewed changes
@Adela0814
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@Adela0814 Adela0814 marked this pull request as draft December 20, 2023 08:07
@luncliff
Copy link
Contributor Author

luncliff commented Dec 20, 2023 via email

@luncliff luncliff marked this pull request as ready for review December 24, 2023 10:47
@luncliff luncliff requested a review from Adela0814 December 24, 2023 10:47
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Dec 25, 2023
@vicroms vicroms merged commit e64dd33 into microsoft:master Dec 28, 2023
15 checks passed
@dg0yt
Copy link
Contributor

dg0yt commented Dec 28, 2023 •
edited
Loading

@vicroms IMO this port must be immediately renamed to lfreist-hwinfo.

  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.

I think this is wrong. All repology references point to https://github.com/opensuse/hwinfo:
https://repology.org/project/hwinfo/information

@luncliff
Copy link
Contributor Author

Checked the email too late. I think reverting this PR is ok.

@luncliff luncliff deleted the port/hwinfo branch January 2, 2024 01:26
dg0yt added a commit to dg0yt/vcpkg that referenced this pull request Jan 2, 2024
@dg0yt
Revert "[hwinfo] create a new port (microsoft#35465)"
e2836f5 
This reverts commit e64dd33.
@dg0yt dg0yt mentioned this pull request Jan 2, 2024
Merged
BillyONeal pushed a commit that referenced this pull request Jan 2, 2024
@dg0yt
Revert "[hwinfo] create a new port (#35465)" (#35993)
8de7ffa 
This reverts commit e64dd33.
autoantwort pushed a commit to autoantwort/vcpkg that referenced this pull request Jan 3, 2024
@dg0yt @autoantwort
Revert "[hwinfo] create a new port (microsoft#35465)" (microsoft#35993)
7e86d63 
This reverts commit e64dd33.
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
@luncliff @Osyotr
[hwinfo] create a new port (microsoft#35465)
ac8217b 
* [hwinfo] create a new port

* [hwinfo] update baseline

* [hwinfo] can't use WbemIdl in UWP

* [hwinfo] suppress NO_OCL unused

* it's just not accessed in CMakeLists.txt

* [hwinfo] fix NO_OCL expression
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
@dg0yt @Osyotr
Revert "[hwinfo] create a new port (microsoft#35465)" (microsoft#35993)
964613e 
This reverts commit e64dd33.
@moritz-h moritz-h mentioned this pull request Aug 29, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adela0814 Adela0814 Adela0814 approved these changes

Assignees

@Adela0814 Adela0814

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luncliff @BillyONeal @Adela0814 @dg0yt @vicroms