-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python3] cross compile python3 for android on linux #33078
[python3] cross compile python3 for android on linux #33078
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR #31621 is not dead. The work was put on hold by the pending update to python 3.11.
ports/python3/0016-explicit-define-ctypes_pythonapi-for-Android.patch
Outdated
Show resolved
Hide resolved
FTR there are also users who build for Android on Windows or macOS. |
At present, the version information of your commit is inconsistent with your local one:
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented before, this PR doesn't properly deal with triplets and toolchains.
Getting it right will throw you on the changes which I already have in #31621. (And in particular in #31228 - vcpkg maintainers, are you listening?)
Given that the python changes are expensive in vcpkg CI, I would really recommend alignment of these activities.
What I still might need to integrate is the INSTSONAME and ctypes changes. If these changes are needed, they should also be upstreamed.
Which you mentioned are all resolved, please review again. I have seen #31621, but I don't think they are conflict. I'm attemping to upstream the patches. |
@MonicaLiu0311 @dg0yt Please approve this pull request |
@LilyWangLL Could anybody merge this pr? |
My position is unchanged:
But you will need wait for the vcpkg owners to decide. |
Mark |
I know your PR #31621 addresses the nature of cross-compile, however this PR is more inclined to aim at creating a python interpreter and binary artifact that meets runtime expectations on Android.
|
And consistently passing on the flags is the key contribution from #31621. It is not just a python3 or Android problem. Any workaround is technical debt. And not supporting osx hosts immediately calls for the next PR. With a single line of change. |
Please resolve the conflict. |
Ping @Arlen-LT |
Fixed #30501
./vcpkg x-add-version --all
and committing the result.Description
This PR primarily addresses the cross-compilation-for-android issue.
Changes Made
Validation