Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure-iot-sdk-c] LTS_08_2023 #33016

Merged
merged 8 commits into from
Aug 10, 2023
Merged

[azure-iot-sdk-c] LTS_08_2023 #33016

merged 8 commits into from
Aug 10, 2023

Conversation

RLeclair
Copy link
Member

@RLeclair RLeclair commented Aug 7, 2023

[azure-iot-sdk-c] LTS_08_2023

dg0yt
dg0yt reviewed Aug 7, 2023
View reviewed changes
ports/azure-iot-sdk-c/vcpkg.json Outdated
@@ -1,6 +1,6 @@
{
"name": "azure-iot-sdk-c",
"version-date": "2023-08-06",
"version-date": "2023-08-03",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we are moving backwards.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed control date forward to 2023-08-06

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed to 2023-08-07

@RLeclair
Copy link
Member Author

RLeclair commented Aug 7, 2023

Hi @dg0yt, anything else needed to merge this PR?

@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 8, 2023
FrankXie05
FrankXie05 requested changes Aug 8, 2023
View reviewed changes
ports/azure-macro-utils-c/vcpkg.json Outdated
@@ -1,6 +1,6 @@
{
"name": "azure-macro-utils-c",
"version-date": "2022-01-21",
"version-date": "2023-08-07",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the corresponding portfile.cmake file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. either don't update the version-date, or actually update the port.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed update to version-date

ports/umock-c/vcpkg.json Outdated
@@ -1,6 +1,6 @@
{
"name": "umock-c",
"version-date": "2022-01-21",
"version-date": "2023-08-07",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vcpkg/ports/umock-c/portfile.cmake

Line 6 in ad46340

REF 504193e65d1c2f6eb50c15357167600a296df7ff

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be explicit?
Either don't update the version-date, or actually update the port.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed update to version-date

@FrankXie05
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

@FrankXie05 FrankXie05 marked this pull request as draft August 8, 2023 06:33
dg0yt
dg0yt suggested changes Aug 8, 2023
View reviewed changes
ports/umock-c/vcpkg.json Outdated
@@ -1,6 +1,6 @@
{
"name": "umock-c",
"version-date": "2022-01-21",
"version-date": "2023-08-07",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be explicit?
Either don't update the version-date, or actually update the port.

ports/azure-macro-utils-c/vcpkg.json Outdated
@@ -1,6 +1,6 @@
{
"name": "azure-macro-utils-c",
"version-date": "2022-01-21",
"version-date": "2023-08-07",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. either don't update the version-date, or actually update the port.

@RLeclair RLeclair marked this pull request as ready for review August 8, 2023 15:04
FrankXie05
FrankXie05 reviewed Aug 9, 2023
View reviewed changes
versions/a-/azure-c-shared-utility.json Outdated
{
"git-tree": "ae2cd1418fa9f6d28a8e515d972c1eb982ed7df8",
"version-date": "2023-08-07",
"port-version": 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"port-version": 1
"port-version": 0

Need to delete the port-version field in the vcpkg.json, and use the command ./vcpkg x-add-version

Copy link
Member Author

@RLeclair RLeclair Aug 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FrankXie05, I removed port-version

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Aug 10, 2023
@JavierMatosD JavierMatosD merged commit a03fa63 into microsoft:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt requested changes

@vaavva vaavva vaavva approved these changes

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RLeclair @FrankXie05 @dg0yt @vaavva @JavierMatosD