Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drogon] fix drogon_ctl command not found error #32870

Merged

Conversation

hexorer
Copy link
Contributor

@hexorer hexorer commented Aug 1, 2023

The drogon library provides a cmake function drogon_create_view that uses its drogon_ctl too. but it uses drogon_ctl by PATH env instead of using cmake's find_program. this causes error when drogon_create_view is being used by dependee.

This patch fixes that to use find_program.

I've also additionally prefixed patches by 001... numbers.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@hexorer hexorer marked this pull request as ready for review August 1, 2023 10:27
@hexorer hexorer changed the title Fix/ports/drogon/drogon ctl command [drogon] fix drogon_ctl command not found error Aug 1, 2023
@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Aug 2, 2023
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Aug 3, 2023
@JavierMatosD JavierMatosD merged commit b3d05b2 into microsoft:master Aug 3, 2023
@ericel
Copy link

ericel commented Feb 9, 2024

This is still a problem with the latest dragon builds in docker.

Use Ubuntu 20.04 LTS as a base image

FROM ubuntu:20.04

@hexorer hexorer deleted the fix/ports/drogon/drogon_ctl_command branch June 21, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants