Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gmp] No asm for mingw-dynamic #29782

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[gmp] No asm for mingw-dynamic #29782

merged 1 commit into from
Feb 23, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Feb 22, 2023

When enabling assembler (incl. runtime selection via feature "fat"), only functions implemented in C appear in the import lib for mingw dynamic. This breaks downstream ports such as nettle.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Neumann-A
Copy link
Contributor

Hmm is this an issue for static builds or only for dynamic builds? Maybe the default visibility needs to be switched?

@Adela0814 Adela0814 added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Feb 22, 2023
@Neumann-A
Copy link
Contributor

hmm gmp[core,fat]:x64-windows doesn't build for me. I get a bunch of E:\vcpkg_folders\master_clean\buildtrees\gmp\src\v6.2.1-0c723d4b6f.clean\gmp-impl.h(4657): error C2071: 'add_n': illegal storage class

@dg0yt
Copy link
Contributor Author

dg0yt commented Feb 22, 2023

I can't say much about windows triplets (clang-cl). This PR is for mingw (gcc).
However, I can confirm that mpn_add_n is one of the missing functions with asm for x64-mingw-dynamic.
Providing a list of exported symbols may be a better fix, but I can't handle this ATM.

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Feb 23, 2023
@JavierMatosD JavierMatosD merged commit ec96844 into microsoft:master Feb 23, 2023
@dg0yt dg0yt deleted the gmp branch February 24, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants