Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gtest] Update version to 1.13.0 #29772

Merged
merged 2 commits into from
Feb 23, 2023
Merged

[gtest] Update version to 1.13.0 #29772

merged 2 commits into from
Feb 23, 2023

Conversation

horenmar
Copy link
Contributor

@horenmar horenmar commented Feb 21, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory. -- I actually believe that the clang-tidy patch goes against vcpkg rules about only modifying upstream when necessary for packaging, but upstream has not changed to make it obsolete 🤷 .
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/gtest/vcpkg.json b/ports/gtest/vcpkg.json
index cfa5053..8f9d4ce 100644
--- a/ports/gtest/vcpkg.json
+++ b/ports/gtest/vcpkg.json
@@ -1,7 +1,6 @@
 {
   "name": "gtest",
   "version-semver": "1.13.0",
-  "port-version": 0,
   "description": "GoogleTest and GoogleMock testing frameworks",
   "homepage": "https://github.com/google/googletest",
   "license": "BSD-3-Clause",
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gtest have changed but the version was not updated
version: 1.13.0
old SHA: 88117ddab2092390b69f75ef14bcf4d180c07823
new SHA: d388d021abdf1562032aed1587f8bc201a480918
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@horenmar
Copy link
Contributor Author

How do I get the failed build logs out of the CI?

@autoantwort
Copy link
Contributor

2022-12-23_15-25-11.mp4

@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 22, 2023
@jimwang118
Copy link
Contributor

Tested usage successfully by the gtest:x64-windows triplet.

@JavierMatosD JavierMatosD merged commit 1afeba9 into microsoft:master Feb 23, 2023
@horenmar horenmar deleted the update-gtest-1.13.0 branch February 23, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants