Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mujs] Missing fixes #29635

Merged
merged 6 commits into from
Feb 13, 2023
Merged

[mujs] Missing fixes #29635

merged 6 commits into from
Feb 13, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Feb 13, 2023

Follow-up from #29543:

  • Fix name of unofficial cmake config.
  • Fix version information of cmake config.
  • Add and document official usage: mujs.pc (as in upstream makefile)
  • Link libm when available (as in upstream makefile)
  • Enable shared linkage for non-windows (as in upstream makefile)
  • Cleanup

Extras remarks (not adressed):


  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JavierMatosD
Copy link
Contributor

Thanks for the fix @dg0yt. This looks much better.

@as-shura
Copy link
Contributor

as-shura commented Feb 13, 2023

Why all those changes I was not aware of? Are those new requirements for all future ports?

@JavierMatosD JavierMatosD merged commit 25f6132 into microsoft:master Feb 13, 2023
@dg0yt
Copy link
Contributor Author

dg0yt commented Feb 14, 2023

Why all those changes I was not aware of? Are those new requirements for all future ports?

Some changes are identical to what I requested for mupdf, your other PR.
Some changes are for old port shortcomings with regard to upstream.
Some changes are pure cleanup.
It is all based on the current maintainer guidelines.
To discuss all those issues, it needs fair time for review and constructive communication.

@dg0yt dg0yt deleted the mujs branch February 14, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants