Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arg-router] Bump to 1.1.1 #29604

Merged
merged 2 commits into from
Feb 15, 2023
Merged

[arg-router] Bump to 1.1.1 #29604

merged 2 commits into from
Feb 15, 2023

Conversation

cmannett85
Copy link
Contributor

Bug fixes:

  • Critical issue that prevents non-CMake builds from being built

Improvements:

  • Removed the git patch version segment and therefore the requirement on git to build. This allows for building from source without a working copy
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@cmannett85
[arg-router] Bump to 1.1.1
96a9f2e 
Bug fixes:
* Critical issue that prevents non-CMake builds from being built

Improvements:
* Removed the git patch version segment and therefore the requirement on git to build. This allows for building from source without a working copy
github-actions[bot]
github-actions bot previously approved these changes Feb 11, 2023
View reviewed changes
@cmannett85 cmannett85 marked this pull request as ready for review February 11, 2023 20:29
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Feb 13, 2023
LilyWangLL
LilyWangLL requested changes Feb 13, 2023
View reviewed changes
dg0yt
dg0yt reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC it is a header-only port. Instead of building and removing the debug variant, we could add this before configure:

set(VCPKG_BUILD_TYPE release) # header-only port

@cmannett85
Changes fro PR comments
fb2f42c 
* Removed unused files
* Added vcpkg_cmake_config_fixup
* Restricted to release 'build'
* Used version var for source tag
@cmannett85
Copy link
Contributor Author

I've made the changes requested, I don't know why the 'requires:author-response' label is still here.

@cmannett85 cmannett85 requested review from LilyWangLL and dg0yt and removed request for LilyWangLL and dg0yt February 15, 2023 10:24
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Feb 15, 2023
@JavierMatosD JavierMatosD merged commit ee71be7 into microsoft:master Feb 15, 2023
@cmannett85 cmannett85 deleted the issue_246 branch February 15, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmannett85 @dg0yt @LilyWangLL @JavierMatosD