[opusfile] Disable opusurl on Windows, update to 9d71834 #29603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was recommended to fix dependency issues in sdl2-mixer. See microsoft#29487 (comment) This commit brings first-party CMake support and minor fixes with no API change.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dg0yt
reviewed
Feb 11, 2023
ports/opusfile/usage
Outdated
Comment on lines
6
to
7
| # If opusurl is built | ||
| target_link_libraries(main PRIVATE OpusFile::opusurl) |
There was a problem hiding this comment.
Is this needed if (feature) opusurl is built, or in order to use opusurl API?
In the first case, I would expect OpusFile::opusurl to come automatically with OpusFile::opusfile. In the second case, I would suggest to modify the comment.
There was a problem hiding this comment.
Thank you for the feedback. I updated the comment to hopefully disambiguate the usage. Linking OpusFile::opusurl is only needed to use its API.
Cheney-W
added
the
category:port-update
Cheney-W
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.Fixes #29582
Create a new release including this range of commits: xiph/opusfile@v0.12...9d71834. This does not alter the API of v0.12, but bring first party CMake support. Most notably, this version installs an official CMake config file which tracks its usage dependencies libogg and opus (see #29487 (comment) cc: @dg0yt).