Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[roaring] Update to 0.9.6 #29579

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

yuyoyuppe
Copy link
Contributor

@yuyoyuppe yuyoyuppe commented Feb 10, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

github-actions[bot]
github-actions bot previously approved these changes Feb 10, 2023
@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 13, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for roaring have changed but the version was not updated
version: 0.9.5#1
old SHA: 276a13d125a717cdb68f9da210c815288488eed0
new SHA: 18bbda1279131edd1920a3d71a31d7e1a647e3d6
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 371892cc20c3b81e5f609e898ab78875fc4d3d72 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index a894409..305c5b5 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6861,7 +6861,7 @@
       "port-version": 0
     },
     "roaring": {
-      "baseline": "0.9.5",
+      "baseline": "0.9.6",
       "port-version": 1
     },
     "robin-hood-hashing": {
diff --git a/versions/r-/roaring.json b/versions/r-/roaring.json
index 1389e89..c19a4a1 100644
--- a/versions/r-/roaring.json
+++ b/versions/r-/roaring.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a26be3e790be16d0fb22e752aa5c9673e6d3ac92",
+      "version": "0.9.6",
+      "port-version": 1
+    },
     {
       "git-tree": "276a13d125a717cdb68f9da210c815288488eed0",
       "version": "0.9.5",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 371892cc20c3b81e5f609e898ab78875fc4d3d72 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index a894409..6901abd 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6861,8 +6861,8 @@
       "port-version": 0
     },
     "roaring": {
-      "baseline": "0.9.5",
-      "port-version": 1
+      "baseline": "0.9.6",
+      "port-version": 0
     },
     "robin-hood-hashing": {
       "baseline": "3.11.5",
diff --git a/versions/r-/roaring.json b/versions/r-/roaring.json
index 1389e89..2ddaefc 100644
--- a/versions/r-/roaring.json
+++ b/versions/r-/roaring.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9db14142b67f98cafe5c5cda27162680abd66a45",
+      "version": "0.9.6",
+      "port-version": 0
+    },
     {
       "git-tree": "276a13d125a717cdb68f9da210c815288488eed0",
       "version": "0.9.5",

@jimwang118
Copy link
Contributor

You should run the command: ./vcpkg x-add-version --all to update the database version. You can get more information from maintainer-guide.md.

@yuyoyuppe yuyoyuppe changed the title [roaring] Update to 0.9.5 [roaring] Update to 0.9.6 Feb 13, 2023
@yuyoyuppe yuyoyuppe requested a review from jimwang118 February 13, 2023 08:50
@yuyoyuppe
Copy link
Contributor Author

@jimwang118 updated, PTAL.

@jimwang118
Copy link
Contributor

All test passed with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 13, 2023
@JavierMatosD JavierMatosD merged commit 357d361 into microsoft:master Feb 13, 2023
@yuyoyuppe yuyoyuppe deleted the update_roaring branch February 13, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants