Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icu] Fix x86 MinGW build #29532

Merged
merged 1 commit into from
Feb 9, 2023
Merged

[icu] Fix x86 MinGW build #29532

merged 1 commit into from
Feb 9, 2023

Conversation

koprok
Copy link
Contributor

@koprok koprok commented Feb 8, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

dg0yt

This comment was marked as resolved.

Sign in to view

@koprok
Copy link
Contributor Author

koprok commented Feb 8, 2023

@dg0yt, the fix is for x86-mingw-dynamic triplet. Without this fix the build itself passes with no errors, but the DLLs are not present in bin folder.

@koprok
Copy link
Contributor Author

koprok commented Feb 8, 2023

This happens because portfile.cmake expects the DLLs to be in the lib folder in build tree. It patches config/mh-mingw64 to make it so. But config/mh-mingw64 is used only for 64-bit build. For 32-bit build config/mh-mingw file has to be patched in the same way.

@koprok koprok marked this pull request as ready for review February 8, 2023 21:54
dg0yt
dg0yt approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for the explanation. For now, this PR is the right step.

@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Feb 9, 2023
@jimwang118 jimwang118 requested a review from JonLiu1993 February 9, 2023 05:51
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Feb 9, 2023
@JavierMatosD JavierMatosD merged commit f67d913 into microsoft:master Feb 9, 2023
@koprok koprok deleted the icu branch February 10, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

@jimwang118 jimwang118

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koprok @dg0yt @JonLiu1993 @JavierMatosD @jimwang118