[azure-security-attestation-cpp] Update to 1.1.0 #29516
Conversation
## 1.1.0 (2023-02-07) ### Breaking Changes - Changed `AttestationClient::AttestTpm` to match `AttestOpenEnclave` and `AttestSgxEnclave`: - Added `std::vector<uint8_t>` dataToAttest parameter to the `AttestTpm()` client method. - Removed `Payload` in `TpmAttestationOptions`. - Changed `TpmResult` in `TpmAttestationResult` to type `std::vector<uint8_t>`.
|
Adding azure-security-attestation to release cc: @LarryOsterman, @gkostal, @anilba06, @kroshkina-ms, @ahmadmsft, @RickWinter, @ahsonkhan, @antkmsft, @vhvb1989, @gearama |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cheney-W
added
the
category:port-update
| @@ -1,8 +1,8 @@ | |||
| vcpkg_from_github( | |||
| OUT_SOURCE_PATH SOURCE_PATH | |||
| REPO Azure/azure-sdk-for-cpp | |||
| REF azure-security-attestation_1.0.0 | |||
| SHA512 75b616ea152a88b2cd3be261df134523f1743343542f005e85f1dc9d438584038d0d92879c3caabfd3bd60c6c37c658ad327b2fb62693d99c170e64182f6831f | |||
| REF azure-security-attestation_1.1.0 | |||
There was a problem hiding this comment.
| REF azure-security-attestation_1.1.0 | |
| REF "azure-security-attestation_${VERSION}" |
There was a problem hiding this comment.
cc: @LarryOsterman, @gkostal, @anilba06, @kroshkina-ms, @ahmadmsft, @RickWinter, @ahsonkhan, @antkmsft, @vhvb1989, @gearama
There was a problem hiding this comment.
Thank you @Cheney-W, we'll consider switching to use that feature in the future. I don't think we should take if for this PR, but please comment if you strongly believe that we should.
At this point, updating it for the port would require us to re-run the x-add-version command, but for the change to be permanent, in needs to go to our repo. We use file templates to produce manifest files for the vcpkg, and our CI does the version substitution. To fully update it, we'll need to update CI scripts as well. We could do it, but in the future.
More off topic:
There is one effort that I would like to happen, once we accumulate the set of changes that we need to apply.
I'd love to update our SDK so that we can use the same manifest files for development mode and for pushing the release to vcpkg. But currently, I think, it requires the version to be present in the vcpkg.json file, which won't work for us, because our source of truth for the version is the header file in the repo, from where it is taken and version replacement happens for the vcpkg manifest files during the port update. Which means, we can't as easily keep version-semver in the vcpkg.json to be in sync with the header file in our repo.
For this specific feature, I am not sure if it is necessarily convenient for development and for human error prevention. When you have aa specific tag there, you can be more certain that the vcpkg is trying to fetch the version that you expect and see. Besides, SHA512 needs to be updated anyways.
But, we need to think about it. I don't think we'd take it for this PR, unless it is a thing that you are applying across multiple ports as sort of the centralized effort. We surely want to be cooperative if that's the case.
BTW, is there a document where col features like this one with ${VERSION} are documented? Or maybe some "what's new" type of list with the newest features added that we can follow? We created the infrastructure for vcpkg releases about 2 years ago, and since then many good features were added. We did adopt some (switching from CONTROL file to vcpkg.json, using version>= once it went mainstream etc), but maybe there are even more that we can adopt.
There was a problem hiding this comment.
we'll consider switching to use that feature in the future. I don't think we should take if for this PR
+1
Our releases aren't done manually.
We'd want to get this port update released and available for customers (as-is), and modify our repo and automation to use such new features, in the future.
BTW, is there a document where col features like this one with ${VERSION} are documented?
@BillyONeal, @ras0219-msft - thoughts?
There was a problem hiding this comment.
This is the documentation about VERSION: https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_common_definitions.md#:~:text=VERSION%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20The%20version%20of%20the%20port%20that%20is%20currently%20being%20built
This is the latest release documentation of vcpkg: https://devblogs.microsoft.com/cppblog/vcpkg-2023-01-09-release-registry-pattern-matching-documentation-changes-and-more/
This is only a suggestion and it is not necessary to modify in this PR. Hope you guys can add it to your scripts.
Cheney-W
added
requires:author-response
info:reviewed
Update vcpkg ports for Azure SDK release. This release may contain multiple ports.