[opusfile] Generate .pc files and modernise portfile #29511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for SDL_mixer. (see microsoft#29487)
- Use `${VERSION}` for the REF.
- Use `vcpkg_check_features` to check for opusurl.
- Replace deprecated functions with the ones from `vcpkg-cmake`.
- Use `vcpkg_replace_string` to edit the header.
- Use `vcpkg_install_copyright` to install the license.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/opusfile/vcpkg.json
Valid values for the license field can be found in the documentation
MonicaLiu0311
added
the
category:port-bug
MonicaLiu0311
previously approved these changes
Feb 8, 2023
MonicaLiu0311
added
the
info:reviewed
|
I would assume that we also need debug variants of the pc files. |
FtZPetruska
dismissed stale reviews from MonicaLiu0311 and github-actions[bot]
via
44e956d
You're correct, I've added them in e7b683f. Thank you for the feedback! |
dg0yt
reviewed
Feb 8, 2023
MonicaLiu0311
removed
the
info:reviewed
MonicaLiu0311
approved these changes
Feb 9, 2023
MonicaLiu0311
added
the
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.This PR allows the creating of .pc files for
opusfileandopusurl. This is needed for #29487.Additionally, the portfile was modernised to replace deprecated functions, use
${VERSION}, and usevcpkg_functions instead of doing things manually.There is also an issue building
opusurlon Windows, but it does not seem to be related to this PR, as build was already failing on themasterbranch.