[boost] fix emscripten build #29481
Merged
[boost] fix emscripten build #29481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for boost-modular-build-helper have changed but the version was not updated
version: 1.81.0#1
old SHA: 6e28e9a445dc3442e89761e500fbb8bb5e175c00
new SHA: 901e950fd90fca536c98289e5f2f9beac7d959de
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Pospelove
changed the title
JonLiu1993
added
the
category:community-triplet
JonLiu1993
approved these changes
Feb 7, 2023
|
@Pospelove Maybe you could take a look at this new emscripten boost build failure that just popped up? #29529 |
|
@tobbi Yeah, I think so, I'll take a look. |
|
|
@tobbi ok I see, thanks |
This was referenced Feb 8, 2023
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Feb 18, 2023
…rts.ps1. microsoft#29540 and microsoft#29481 forgot to rerun generate-ports.ps1. Note that the default port-version was bumped because most everything depends on boost-build that change touched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #27641
fixes #28423
fixes #29470
this PR adds support for non-header-only Boost libraries build under Emscripten
tested with:
proven .a files in /lib and /debug/lib and headers in /include
while my changes seem to work, I'm looking forward to your review. I'm not familiar with b2 so I probably did in CMake too much
see also
https://github.com/boostorg/build/blob/develop/src/tools/emscripten.jam
https://www.boost.org/doc/libs/1_81_0/tools/build/doc/html/index.html#bbv2.extending.toolset_modules