[ceres] Fix missing iOS deployment target #29432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BillyONeal
reviewed
Feb 4, 2023
| set(TARGET_OPTIONS ) | ||
| if(VCPKG_TARGET_IS_IOS) | ||
| # Note: CMake uses "OSX" not just for macOS, but also iOS, watchOS and tvOS. | ||
| list(APPEND TARGET_OPTIONS "-DIOS_DEPLOYMENT_TARGET=${VCPKG_OSX_DEPLOYMENT_TARGET}") |
There was a problem hiding this comment.
Should this be something we do in the ios triplets rather than doing it in an individual port like this?
There was a problem hiding this comment.
The IOS_DEPLOYMENT_TARGET variable that Ceres is using isn't a CMake standard variable. It's something from their custom iOS build chain, and it won't build without it being set. Normally it should be using CMAKE_OSX_DEPLOYMENT_TARGET, but we can just copy it to the other variable to make Ceres happy.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.Ceres expects the iOS target version to passed in
IOS_DEPLOYMENT_TARGET, and even forcibly unsetsCMAKE_OSX_DEPLOYMENT_TARGET.