Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libusb] Fix undefined symbols on osx #29393

Merged
merged 5 commits into from
Feb 3, 2023

Conversation

xiaozhuai
Copy link
Contributor

  1. Fix undefined symbols on osx
Undefined symbols for architecture x86_64:
  "_CFBooleanGetTypeID", referenced from:
      _darwin_detach_kernel_driver in libusb-1.0.a(darwin_usb.o)
  "_CFBooleanGetValue", referenced from:
      _darwin_detach_kernel_driver in libusb-1.0.a(darwin_usb.o)
  "_CFDataGetBytes", referenced from:
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
  "_CFDataGetLength", referenced from:
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
  "_CFDataGetTypeID", referenced from:
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
  "_CFDictionaryCreateMutable", referenced from:
      _usb_find_interface_matching_location in libusb-1.0.a(darwin_usb.o)
  "_CFDictionarySetValue", referenced from:
      _usb_find_interface_matching_location in libusb-1.0.a(darwin_usb.o)
  "_CFGetTypeID", referenced from:
      _darwin_detach_kernel_driver in libusb-1.0.a(darwin_usb.o)
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
      _get_ioregistry_value_number in libusb-1.0.a(darwin_usb.o)
      _darwin_devices_detached in libusb-1.0.a(darwin_usb.o)
  "_CFNumberCreate", referenced from:
      _usb_find_interface_matching_location in libusb-1.0.a(darwin_usb.o)
  "_CFNumberGetTypeID", referenced from:
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
      _get_ioregistry_value_number in libusb-1.0.a(darwin_usb.o)
      _darwin_devices_detached in libusb-1.0.a(darwin_usb.o)
  "_CFNumberGetValue", referenced from:
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
      _get_ioregistry_value_number in libusb-1.0.a(darwin_usb.o)
      _darwin_devices_detached in libusb-1.0.a(darwin_usb.o)
  "_CFRelease", referenced from:
      _darwin_close in libusb-1.0.a(darwin_usb.o)
      _darwin_detach_kernel_driver in libusb-1.0.a(darwin_usb.o)
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
      _get_ioregistry_value_number in libusb-1.0.a(darwin_usb.o)
      _darwin_devices_detached in libusb-1.0.a(darwin_usb.o)
      _darwin_release_interface in libusb-1.0.a(darwin_usb.o)
      ...
  "_CFRetain", referenced from:
      _darwin_open in libusb-1.0.a(darwin_usb.o)
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
  "_CFRunLoopAddSource", referenced from:
      _darwin_open in libusb-1.0.a(darwin_usb.o)
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
      _darwin_claim_interface in libusb-1.0.a(darwin_usb.o)
  "_CFRunLoopGetCurrent", referenced from:
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
  "_CFRunLoopRemoveSource", referenced from:
      _darwin_close in libusb-1.0.a(darwin_usb.o)
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
      _darwin_release_interface in libusb-1.0.a(darwin_usb.o)
  "_CFRunLoopRun", referenced from:
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
  "_CFRunLoopSourceCreate", referenced from:
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
  "_CFRunLoopSourceSignal", referenced from:
      _darwin_exit in libusb-1.0.a(darwin_usb.o)
  "_CFRunLoopStop", referenced from:
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
  "_CFRunLoopWakeUp", referenced from:
      _darwin_exit in libusb-1.0.a(darwin_usb.o)
  "_CFUUIDGetConstantUUIDWithBytes", referenced from:
      _darwin_device_from_service in libusb-1.0.a(darwin_usb.o)
      _darwin_claim_interface in libusb-1.0.a(darwin_usb.o)
  "_CFUUIDGetUUIDBytes", referenced from:
      _darwin_device_from_service in libusb-1.0.a(darwin_usb.o)
      _darwin_claim_interface in libusb-1.0.a(darwin_usb.o)
  "_IOCreatePlugInInterfaceForService", referenced from:
      _darwin_device_from_service in libusb-1.0.a(darwin_usb.o)
      _darwin_claim_interface in libusb-1.0.a(darwin_usb.o)
  "_IOIteratorNext", referenced from:
      _darwin_init in libusb-1.0.a(darwin_usb.o)
      _process_new_device in libusb-1.0.a(darwin_usb.o)
      _darwin_devices_detached in libusb-1.0.a(darwin_usb.o)
      _darwin_devices_attached in libusb-1.0.a(darwin_usb.o)
      _darwin_clear_iterator in libusb-1.0.a(darwin_usb.o)
      _darwin_get_interface in libusb-1.0.a(darwin_usb.o)
  "_IOKitWaitQuiet", referenced from:
      _darwin_hotplug_poll in libusb-1.0.a(darwin_usb.o)
  "_IONotificationPortCreate", referenced from:
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
  "_IONotificationPortDestroy", referenced from:
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
  "_IONotificationPortGetRunLoopSource", referenced from:
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
  "_IOObjectRelease", referenced from:
      _darwin_init in libusb-1.0.a(darwin_usb.o)
      _darwin_exit in libusb-1.0.a(darwin_usb.o)
      _darwin_capture_claim_interface in libusb-1.0.a(darwin_usb.o)
      _darwin_kernel_driver_active in libusb-1.0.a(darwin_usb.o)
      _darwin_destroy_device in libusb-1.0.a(darwin_usb.o)
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
      ...
  "_IOObjectRetain", referenced from:
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
  "_IORegistryEntryCreateCFProperty", referenced from:
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
      _get_ioregistry_value_number in libusb-1.0.a(darwin_usb.o)
      _darwin_devices_detached in libusb-1.0.a(darwin_usb.o)
  "_IORegistryEntryGetChildEntry", referenced from:
      _darwin_capture_claim_interface in libusb-1.0.a(darwin_usb.o)
      _darwin_kernel_driver_active in libusb-1.0.a(darwin_usb.o)
  "_IORegistryEntryGetParentEntry", referenced from:
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
  "_IOServiceAddMatchingNotification", referenced from:
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
  "_IOServiceAuthorize", referenced from:
      _darwin_detach_kernel_driver in libusb-1.0.a(darwin_usb.o)
  "_IOServiceGetMatchingService", referenced from:
      _usb_find_interface_matching_location in libusb-1.0.a(darwin_usb.o)
  "_IOServiceGetMatchingServices", referenced from:
      _darwin_init in libusb-1.0.a(darwin_usb.o)
  "_IOServiceMatching", referenced from:
      _darwin_init in libusb-1.0.a(darwin_usb.o)
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
      _usb_find_interface_matching_location in libusb-1.0.a(darwin_usb.o)
  "_SecTaskCopyValueForEntitlement", referenced from:
      _darwin_detach_kernel_driver in libusb-1.0.a(darwin_usb.o)
  "_SecTaskCreateFromSelf", referenced from:
      _darwin_detach_kernel_driver in libusb-1.0.a(darwin_usb.o)
  "___CFConstantStringClassReference", referenced from:
      CFString in libusb-1.0.a(darwin_usb.o)
      CFString in libusb-1.0.a(darwin_usb.o)
      CFString in libusb-1.0.a(darwin_usb.o)
      CFString in libusb-1.0.a(darwin_usb.o)
      CFString in libusb-1.0.a(darwin_usb.o)
      CFString in libusb-1.0.a(darwin_usb.o)
      CFString in libusb-1.0.a(darwin_usb.o)
      ...
  "_kCFAllocatorDefault", referenced from:
      _darwin_detach_kernel_driver in libusb-1.0.a(darwin_usb.o)
      _darwin_get_cached_device in libusb-1.0.a(darwin_usb.o)
      _get_ioregistry_value_number in libusb-1.0.a(darwin_usb.o)
      _darwin_devices_detached in libusb-1.0.a(darwin_usb.o)
      _usb_find_interface_matching_location in libusb-1.0.a(darwin_usb.o)
  "_kCFAllocatorSystemDefault", referenced from:
      _darwin_device_from_service in libusb-1.0.a(darwin_usb.o)
      _darwin_claim_interface in libusb-1.0.a(darwin_usb.o)
  "_kCFRunLoopCommonModes", referenced from:
      _darwin_open in libusb-1.0.a(darwin_usb.o)
  "_kCFRunLoopDefaultMode", referenced from:
      _darwin_close in libusb-1.0.a(darwin_usb.o)
      _darwin_event_thread_main in libusb-1.0.a(darwin_usb.o)
      _darwin_release_interface in libusb-1.0.a(darwin_usb.o)
      _darwin_claim_interface in libusb-1.0.a(darwin_usb.o)
  "_kCFTypeDictionaryKeyCallBacks", referenced from:
      _usb_find_interface_matching_location in libusb-1.0.a(darwin_usb.o)
  "_kCFTypeDictionaryValueCallBacks", referenced from:
      _usb_find_interface_matching_location in libusb-1.0.a(darwin_usb.o)
ld: symbol(s) not found for architecture x86_64

github-actions[bot]
github-actions bot previously approved these changes Feb 2, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:

  • ports/libusb/vcpkg.json (has deprecated license LGPL-2.1)

Deprecated and non deprecated license identifiers can be found here

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libusb have changed but the version was not updated
version: 1.0.26#3
old SHA: 01d788329687e36ad42b813027dfbc8912bf2b12
new SHA: 540652cc1251aa3894206c20296f6119da1ccea4
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Feb 3, 2023
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Feb 3, 2023
"description": "a cross-platform library to access USB devices",
"homepage": "https://github.com/libusb/libusb",
"license": "LGPL-2.1",
"license": "LGPL-2.1-or-later",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillyONeal BillyONeal merged commit 7229e06 into microsoft:master Feb 3, 2023
@BillyONeal
Copy link
Member

Thanks for the fix!

@xiaozhuai xiaozhuai deleted the dev-libusb branch February 5, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants