Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[physac] Add new port #29365

Merged
merged 1 commit into from
Feb 3, 2023
Merged

[physac] Add new port #29365

merged 1 commit into from
Feb 3, 2023

Conversation

ex-purple
Copy link
Contributor

@ex-purple ex-purple commented Feb 1, 2023

Fixes #22935

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 2, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Feb 2, 2023

file(INSTALL "${SOURCE_PATH}/src/physac.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include")

vcpkg_install_copyright(FILE_LIST "${CMAKE_CURRENT_LIST_DIR}/LICENSE")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vcpkg_install_copyright(FILE_LIST "${CMAKE_CURRENT_LIST_DIR}/LICENSE")
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")

Why did you copy the license file here rather than getting it from the source distribution?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I will make this change for you if you want but this was sufficiently unusual I wanted to understand why you do that :) Thanks for the new port!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The currently used tag is 1.1, which is generated at Nov 3, 2019, but the LICENSE file of upstream is added Jul 24, 2022, so LICENSE file does not exist when downloading 1.1 source.

https://github.com/victorfisac/Physac

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to use vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE"), then we need to download the latest commit of upstream instead of the 1.1 tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I copied the license file here rather than getting it from the source distribution because version 1.1 does not include license file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that that was changed. Thanks for clarifying!

@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines requires:author-response labels Feb 3, 2023
@BillyONeal BillyONeal merged commit fa438cf into microsoft:master Feb 3, 2023
@BillyONeal
Copy link
Member

Thanks for the new port!

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New port request] easings/raygui/physac
3 participants