-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[physac] Add new port #29365
[physac] Add new port #29365
Conversation
|
||
file(INSTALL "${SOURCE_PATH}/src/physac.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include") | ||
|
||
vcpkg_install_copyright(FILE_LIST "${CMAKE_CURRENT_LIST_DIR}/LICENSE") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vcpkg_install_copyright(FILE_LIST "${CMAKE_CURRENT_LIST_DIR}/LICENSE") | |
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE") |
Why did you copy the license file here rather than getting it from the source distribution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I will make this change for you if you want but this was sufficiently unusual I wanted to understand why you do that :) Thanks for the new port!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The currently used tag is 1.1
, which is generated at Nov 3, 2019, but the LICENSE file
of upstream is added Jul 24, 2022, so LICENSE file
does not exist when downloading 1.1 source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to use vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")
, then we need to download the latest commit
of upstream instead of the 1.1
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I copied the license file here rather than getting it from the source distribution because version 1.1 does not include license file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I missed that that was changed. Thanks for clarifying!
Thanks for the new port! |
Fixes #22935
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.