Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poco. #293

Merged
merged 2 commits into from
Nov 17, 2016
Merged

Add poco. #293

merged 2 commits into from
Nov 17, 2016

Conversation

sdcb
Copy link
Contributor

@sdcb sdcb commented Nov 16, 2016

This should fix: #124

Note:
I created a small patch to define POCO_NO_AUTOMATIC_LIBS since vcpkg would do that.
The option POCO_UNBUNDLED is now OFF, we should switch it ON when all dependency is available in vcpkg.

@msftclas
Copy link

Hi @sdcb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@sdcb
Copy link
Contributor Author

sdcb commented Nov 16, 2016

Last commit notes:

Explain:

  1. I removed the depends on "openssl" and "libmariadb" since it does not work as I expected
  2. I switched to use the github.com release instead of the pocoproject.org windows release because that can enable more option
  3. I switched the ENABLE_SEVENZIP on, I think it may be useful for someone.

Note:

  1. I'm not very similar for building static libraries, I did not switch the POCO_MT on because I don't know what that means. Please feel free to do any change when merging
  2. The lib Poco/Data/MySql won't build even if add libmariadb dependency.

@ras0219-msft
Copy link
Contributor

I think we have all the dependencies, so I'm going to try switching UNBUNDLED to ON and merge that if possible. The libraries that appear to be affected by that switch are:

  • zlib
  • pcre
  • expat
  • sqlite3

Additionally, it looks like it can optionally use:

  • openssl (openssl in vcpkg)
  • apr (apr in vcpkg)
  • apache2
  • mysql (libmysql or libmariadb in vcpkg)
  • odbc

@ras0219-msft ras0219-msft merged commit 857f76b into microsoft:master Nov 17, 2016
ras0219-msft added a commit that referenced this pull request Nov 17, 2016
@ras0219-msft
Copy link
Contributor

Thanks for the PR! I made the change to use unbundled libraries.

I needed to also modify PCRE to pre-pre-process the value of PCRE_STATIC into the headers, so the PCRE_STATIC macro now does nothing and the correct PCRE library is loaded based on how PCRE was built. Make sure to update it if you have it already built!

@sdcb sdcb deleted the poco branch November 18, 2016 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support POCO c++ Libraries
3 participants