Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tbb] Update tbb #29238

Merged
merged 6 commits into from
Jan 31, 2023
Merged

[tbb] Update tbb #29238

merged 6 commits into from
Jan 31, 2023

Conversation

Neumann-A
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2023
@Neumann-A
Copy link
Contributor Author

Neumann-A commented Jan 28, 2023

TODO: Fix pkg-config but that is also broken in current baseline (debug missing the suffix; somebody mind checking the file list to tell me if it is always _debug or just on windows?)

github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2023
@JonLiu1993 JonLiu1993 changed the title Update tbb [tbb] Update tbb Jan 29, 2023
@JonLiu1993
Copy link
Member

@Neumann-A, Thanks for your PR, this is ci error log.
Please take a look:

-- Using msys root at D:/downloads/tools/msys2/9a1ec3f33446b195
-- Fixing pkgconfig file: D:/packages/tbb_x86-windows/debug/lib/pkgconfig/tbb32.pc
CMake Error at scripts/cmake/vcpkg_replace_string.cmake:2 (file):
  file failed to open for reading (No such file or directory):

    D:/packages/tbb_x86-windows/debug/lib/pkgconfig/tbb.pc
Call Stack (most recent call first):
  ports/tbb/portfile.cmake:26 (vcpkg_replace_string)
  scripts/ports.cmake:147 (include)

@JonLiu1993 JonLiu1993 added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Jan 29, 2023
@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 30, 2023
@BillyONeal BillyONeal merged commit 2beb86e into microsoft:master Jan 31, 2023
@BillyONeal
Copy link
Member

Thanks for the update!

@Neumann-A Neumann-A deleted the update_tbb branch January 31, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants